Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent nil pointer in GetPullRequestCommitStatusState (#10342) #10344

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Prevent nil pointer in GetPullRequestCommitStatusState (#10342) #10344

merged 1 commit into from
Feb 18, 2020

Conversation

zeripath
Copy link
Contributor

Backport #10342

Ensure that pr.HeadRepo is loaded before using it in GetPullRequestCommitStatusState.

Fixes error on merging with successful commit merge statuses.

@zeripath
Prevent nil pointer in GetPullRequestCommitStatusState (go-gitea#10342)
bc6ad0f 
Ensure that pr.HeadRepo is loaded before using it in GetPullRequestCommitStatusState.

Fixes error on merging with successful commit merge statuses.
@zeripath zeripath added this to the 1.11.2 milestone Feb 18, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 18, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 18, 2020
@zeripath zeripath merged commit df5f1d9 into go-gitea:release/v1.11 Feb 18, 2020
@zeripath zeripath deleted the backport-10342 branch February 18, 2020 20:04
@jolheiser jolheiser mentioned this pull request Mar 2, 2020
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.11.2
Development

Successfully merging this pull request may close these issues.
4 participants
@zeripath @lafriks @jolheiser @GiteaBot